Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make .nav-link color consistent when using buttons #33478

Merged
merged 2 commits into from Mar 31, 2021
Merged

Make .nav-link color consistent when using buttons #33478

merged 2 commits into from Mar 31, 2021

Conversation

kyletsang
Copy link
Contributor

@kyletsang kyletsang commented Mar 25, 2021 •
edited by XhmikosR

@kyletsang kyletsang requested a review from a team as a code owner March 25, 2021 17:20
@XhmikosR XhmikosR added this to Inbox in v5.0.0 via automation Mar 30, 2021
@XhmikosR XhmikosR requested a review from ffoodd March 30, 2021 05:18
ffoodd
ffoodd requested changes Mar 30, 2021
View reviewed changes
Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Would you mind doing the same for hover color, please? They're still inconsistent for now.

v5.0.0 automation moved this from Inbox to Review Mar 30, 2021
@kyletsang
Copy link
Contributor Author

Makes sense! Would you mind doing the same for hover color, please? They're still inconsistent for now.

Done!

@kyletsang kyletsang requested a review from ffoodd March 30, 2021 15:45
ffoodd
ffoodd approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

v5.0.0 automation moved this from Review to Approved Mar 30, 2021
@mdo mdo merged commit 91fa809 into twbs:main Mar 31, 2021
v5.0.0 automation moved this from Approved to Done Mar 31, 2021
@XhmikosR XhmikosR changed the title Make .nav-link color consistent when using buttons Make .nav-link color consistent when using buttons Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffoodd ffoodd ffoodd approved these changes

Assignees
No one assigned
Labels
css v5
Projects
No open projects
v5.0.0
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dynamic tabs nav-link color is inconsistent with regular tabs nav-link color
4 participants
@kyletsang @ffoodd @mdo @GeoSot