Use cached noop function
#33496
Merged
Use cached noop function
#33496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I recall noticing this in the past but forgot to make a separate PR for sure. :) That being said, shouldn't our tests have caught this? I mean |
|
@XhmikosR I suppose, you remember this |
|
Yeah, that's another change :) But I still wonder why this wasn't caught :/ |
rohit2sharma95
force-pushed
the
rohit/noop-handling
branch
from
7da4c18
to
e0fd67d
Compare
Not sure about that but that should be considered in another PR IMO (If that is not needed) @GeoSot. 🙂 |
GeoSot
approved these changes
Apr 9, 2021
patrickhlauke
approved these changes
Apr 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
noopfunction returns a new function every time whenever it is called. So just use thenoopfunction, not the value returned by it (So that the event handler can remove the same function that was attached before).Ref: #33451 (comment)