Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use template literals instead of concatenation #33497

Merged
merged 1 commit into from Mar 30, 2021
Merged

Conversation

rohit2sharma95
Copy link
Collaborator

Replace string concatenation with template literals.

js/src/popover.js Outdated Show resolved Hide resolved
js/src/collapse.js Outdated Show resolved Hide resolved
@XhmikosR
Copy link
Member

For what is worth, we don't enforce template literals. We did at some point, but it seems it's not enforced by xo now.

@XhmikosR XhmikosR added this to Inbox in v5.0.0 via automation Mar 30, 2021
v5.0.0 automation moved this from Inbox to Approved Mar 30, 2021
@XhmikosR XhmikosR merged commit 5cc53a0 into main Mar 30, 2021
v5.0.0 automation moved this from Approved to Done Mar 30, 2021
@XhmikosR XhmikosR deleted the rohit/template-literals branch March 30, 2021 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v5.0.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants