Fix wrong carousel transformation, direction to order #33499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoSot
changed the title
mdo
approved these changes
Apr 7, 2021
XhmikosR
approved these changes
Apr 7, 2021
reviewtypo3org
pushed a commit
to TYPO3/typo3
that referenced
this pull request
Jun 14, 2021
Bootstrap beta3 introduced a regression, which reversed the slide direction. This therefore broke our implementation, since we are using an event listener, evaluating the direction. Because we were not aware of this being "just" a regression instead of an intended API change, we switched the direction in our event listener in #94037, too. In the final 5.0 release, we updated to in #94089, the regression has been fixed, breaking our event listener once again. This is fixed by restoring the initial and correct direction check. Related bootstrap PRs: - twbs/bootstrap#32913 - twbs/bootstrap#33499 Resolves: #94338 Releases: master Change-Id: I0bc4dc2dfd37935fc43e04f311bd850916c31004 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69486 Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by: core-ci <typo3@b13.com> Tested-by: Nikita Hovratov <nikita.h@live.de> Tested-by: Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by: Nikita Hovratov <nikita.h@live.de> Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
TYPO3IncTeam
pushed a commit
to TYPO3-CMS/backend
that referenced
this pull request
Jun 14, 2021
Bootstrap beta3 introduced a regression, which reversed the slide direction. This therefore broke our implementation, since we are using an event listener, evaluating the direction. Because we were not aware of this being "just" a regression instead of an intended API change, we switched the direction in our event listener in #94037, too. In the final 5.0 release, we updated to in #94089, the regression has been fixed, breaking our event listener once again. This is fixed by restoring the initial and correct direction check. Related bootstrap PRs: - twbs/bootstrap#32913 - twbs/bootstrap#33499 Resolves: #94338 Releases: master Change-Id: I0bc4dc2dfd37935fc43e04f311bd850916c31004 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69486 Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by: core-ci <typo3@b13.com> Tested-by: Nikita Hovratov <nikita.h@live.de> Tested-by: Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by: Nikita Hovratov <nikita.h@live.de> Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wrong swipe to direction translation
preview