Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spinner alignment changes #33550

Merged
merged 1 commit into from Apr 5, 2021
Merged

Spinner alignment changes #33550

merged 1 commit into from Apr 5, 2021

Conversation

mdo
Copy link
Member

@mdo mdo commented Apr 4, 2021

Fixes #33524. Uses the same vertical-align value from the Bootstrap Icons project, as even the normal spinners appear to be sitting a little too low still.

@mdo mdo marked this pull request as ready for review April 4, 2021 18:49
@mdo mdo requested a review from a team as a code owner April 4, 2021 18:49
@mdo mdo added this to Inbox in v5.0.0 via automation Apr 4, 2021
v5.0.0 automation moved this from Inbox to Approved Apr 4, 2021
Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@mdo mdo merged commit 062ecf6 into main Apr 5, 2021
v5.0.0 automation moved this from Approved to Done Apr 5, 2021
@mdo mdo deleted the spinner-alignment branch April 5, 2021 03:08
@mdo mdo added this to Inbox in v4.6.1 via automation Apr 5, 2021
@XhmikosR XhmikosR moved this from Inbox to Needs manual backport in v4.6.1 Apr 5, 2021
@XhmikosR XhmikosR moved this from Needs manual backport to Cherry-picked/Manually backported in v4.6.1 May 1, 2021
@XhmikosR XhmikosR moved this from Cherry-picked/Manually backported to Shipped in v4.6.1 May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v4.6.1
Shipped
v5.0.0
  
Done
Development

Successfully merging this pull request may close these issues.

Spinners inside btn-lg are not properly aligned
2 participants