Tab.js: Fixes on click handling #33586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpadev
reviewed
Apr 19, 2021
There was a problem hiding this comment.
Is it realistic that someone would initialize tabs by themself and call show() but expecting that nothing happens when the element is disabled? If not then isDisabled on L70 is redundant I'd say because ignoring disabled elements is handled by the click handler now.
Edit: Hm maybe it's not redundant. There would be a way with jQuery to ignore the isDisabled 🤔
Another Edit: Looks like our spec does exactly what I mentioned. Sorry @GeoSot 😅
GeoSot
force-pushed
the
gs-tabs-should-prevent-default-only-in-case-of-anchor
branch
from
ff7f3ef
to
3a12793
Compare
* use prevent default only if triggered by anchor * disable auto-initialization if trigger is disabled * Remove `isDisabled` check on `show` mehtod, as it is being handled by the click handler
Sorry @GeoSot.. Figured my proposal is breaking our spec and it would be still possible to trigger show via jQuery. Maybe it's better to leave it there even if it's somewhat redundant..
GeoSot
force-pushed
the
gs-tabs-should-prevent-default-only-in-case-of-anchor
branch
2 times, most recently
from
dc97f15
to
9bd99d6
Compare
GeoSot
pushed a commit
to alpadev/bootstrap
that referenced
this pull request
Apr 19, 2021
alpadev
approved these changes
Apr 19, 2021
XhmikosR
deleted the
gs-tabs-should-prevent-default-only-in-case-of-anchor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things did:
isDisabledcheck during click handlingisDisabledcheck on methodshow