refactor: make static selectMenuItem method private
#33589
Merged
+26
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpadev
commented
Apr 9, 2021
requested by rohit2sharma95 - twbs#33479 (comment)
alpadev
force-pushed
the
refactor-dropdown-selectmenuitem
branch
from
f04984c
to
806f8fd
Compare
requested by rohit2sharma95 - https://github.com/twbs/bootstrap/pull/33589/files#r611072197
|
I'd say better do one thing at a time :) |
rohit2sharma95
approved these changes
Apr 11, 2021
XhmikosR
changed the title
selectMenuItem method private
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
X-Ref: #33479 (comment)
@XhmikosR do you want me to address #32954 in the same PR?