Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

form-select[multiple] should not display any indicator/icon #33591

Closed
tkrotoff opened this issue Apr 9, 2021 · 2 comments · Fixed by #33598
Closed

form-select[multiple] should not display any indicator/icon #33591

tkrotoff opened this issue Apr 9, 2021 · 2 comments · Fixed by #33598

Comments

@tkrotoff
Copy link
Sponsor Contributor

tkrotoff commented Apr 9, 2021 •
edited

Under Bootstrap 4 (4.6.0), custom-select[multiple] does not display the select indicator and the is-valid/invalid icon:

<select class="custom-select is-valid" multiple></select>

image

Under Bootstrap 5 (5.0.0-beta3), the new form-select[multiple] does display the select indicator and the is-valid/invalid icon:

<select class="form-select is-valid" multiple></select>

image

This is a regression.
@alecpl
Copy link
Contributor

alecpl commented Apr 9, 2021

Probably fixed by #33411

@tkrotoff
Copy link
Sponsor Contributor Author

tkrotoff commented Apr 9, 2021

IMHO the PR is wrong/not enough, see my comment here: #33411 (comment)

@tagliala tagliala mentioned this issue Apr 9, 2021
Merged
tagliala added a commit to tagliala/bootstrap that referenced this issue Apr 13, 2021
@tagliala
Hide validation icons from multiple selects
491095a 
Implementation provided in twbs#33411 does not take into account that some
Operating Systems may display a vertical scrollbar in the multiple
select field

This implementation will hide the validation icons from multiple select
fields, just like Bootstrap 4 does.

Fix: twbs#33591
mdo pushed a commit that referenced this issue Apr 14, 2021
@tagliala @mdo
Hide validation icons from multiple selects
6fe75df 
Implementation provided in #33411 does not take into account that some
Operating Systems may display a vertical scrollbar in the multiple
select field

This implementation will hide the validation icons from multiple select
fields, just like Bootstrap 4 does.

Fix: #33591
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hide validation icons from multiple selects tagliala/bootstrap
2 participants
@alecpl @tkrotoff