tests: fix random BrowserStack failures in scrollbar #33612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoSot
force-pushed
the
gs-fix-some-tests
branch
from
0553c7e
to
faf721e
Compare
GeoSot
changed the title
GeoSot
force-pushed
the
gs-fix-some-tests
branch
from
faf721e
to
b892b49
Compare
XhmikosR
changed the title
|
@XhmikosR I tried to figure the problem locally and I couldn't verify why some of those tests are flaky. From looking at the code I suspect there could be a race condition but it doesn't really make sense as things are properly handled by events. I ran tests on Mac for like 20-30 times and they didn't fail once. Those changes might be a bit overkill but I guess they would at least assure the body is at clean state. |
alpadev
reviewed
Apr 14, 2021
alpadev
approved these changes
Apr 14, 2021
GeoSot
force-pushed
the
gs-fix-some-tests
branch
from
fbae755
to
2994c50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.