Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clicking an item in navbar dropdown should not collapse the dropdown in firefox #33643

Merged
merged 2 commits into from Apr 18, 2021

Conversation

alpadev
Copy link
Contributor

@alpadev alpadev commented Apr 15, 2021

fixes #33592

Background

When clicking on an option of a select element the event.target in Firefox matches the option element itself unlike the select element like in other browsers.

@alpadev alpadev requested a review from a team as a code owner April 15, 2021 10:16
@XhmikosR XhmikosR added this to Inbox in v5.0.0 via automation Apr 15, 2021
@GeoSot GeoSot moved this from Inbox to Review in v5.0.0 Apr 15, 2021
v5.0.0 automation moved this from Review to Approved Apr 15, 2021
@alpadev alpadev changed the title fix: clicking an item in navbar dropdown collapses the dropdown in firefox fix: clicking an item in navbar dropdown should not collapse the dropdown in firefox Apr 15, 2021
@GeoSot
Copy link
Member

GeoSot commented Apr 15, 2021

@alpadev try to put a minor case to the proper test

@XhmikosR XhmikosR merged commit 6d312b3 into twbs:main Apr 18, 2021
v5.0.0 automation moved this from Approved to Done Apr 18, 2021
@XhmikosR
Copy link
Member

Would be nice to have the test indeed, I missed that it was pending. See if you can take care of it later @alpadev :)

alpadev added a commit to alpadev/bootstrap that referenced this pull request Apr 23, 2021
@alpadev alpadev deleted the fix-dropdown-select-ff branch May 13, 2021 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v5.0.0
  
Done
Development

Successfully merging this pull request may close these issues.

[v5-b3] Using a select menu in a dropdown in a navbar collapses the dropdown menu
3 participants