Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix W3C validation errors in list-group example #33664

Merged
merged 1 commit into from Apr 17, 2021
Merged

Docs: fix W3C validation errors in list-group example #33664

merged 1 commit into from Apr 17, 2021

Conversation

k99sharma
Copy link
Contributor

@k99sharma k99sharma commented Apr 16, 2021

Fixes #33650

Prefixed the value of aria-controls with list- to match with tabpanel ids in Javascript behavior example in List Group Component.

Screenshot (18)

Prefixed the `aria-controls` with `list-` to match with `tabpanel`
ids in `Javascript behavior` example in `List Group Component`.
Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌 Thanks !

@mdo mdo added this to Inbox in v5.0.0 via automation Apr 17, 2021
@mdo mdo merged commit 95aec47 into twbs:main Apr 17, 2021
v5.0.0 automation moved this from Inbox to Done Apr 17, 2021
@XhmikosR XhmikosR changed the title Docs: Tried to fix issue #33650 Docs: fix W3C validation errors in list-group example Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.0.0
  
Done
3 participants