Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal.js: fix test for scrollbar #33666

Merged
merged 2 commits into from Apr 19, 2021
Merged

Modal.js: fix test for scrollbar #33666

merged 2 commits into from Apr 19, 2021

Conversation

GeoSot
Copy link
Member

@GeoSot GeoSot commented Apr 17, 2021

Change the timing of scrolllbarGetWidth on test

@GeoSot GeoSot requested a review from a team as a code owner April 17, 2021 08:56
@GeoSot GeoSot added this to Inbox in v5.0.0 via automation Apr 17, 2021
@alpadev
Copy link
Contributor

alpadev commented Apr 17, 2021

Likely better that way. When the modal is shown there is expected to be overflow hidden on the body so getScrollbarWidth would return 0. 👍

@GeoSot GeoSot requested a review from alpadev April 17, 2021 21:34
@XhmikosR XhmikosR moved this from Inbox to Review in v5.0.0 Apr 18, 2021
@XhmikosR
Copy link
Member

I rerun the CI jobs a few times and it seems to be passing consistently.

v5.0.0 automation moved this from Review to Approved Apr 18, 2021
@mdo mdo merged commit 6ea4dab into main Apr 19, 2021
v5.0.0 automation moved this from Approved to Done Apr 19, 2021
@mdo mdo deleted the gs-minor-fix-on-test branch April 19, 2021 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.0.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants