Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V5 Grid System docs issues #33670

Closed
kohheepeace opened this issue Apr 18, 2021 · 3 comments
Closed

V5 Grid System docs issues #33670

kohheepeace opened this issue Apr 18, 2021 · 3 comments

Comments

@kohheepeace
Copy link
Contributor

kohheepeace commented Apr 18, 2021

I've found docs issue at
https://getbootstrap.com/docs/5.0/layout/grid/#example

📌 Issue

2021-04-18_19h41_22

Does col-sm creates three equal-width columns across all devices and viewports?

📌 Issue example

The below image is layout of iPhone 6 plus. It doesn't create 3 columns.
2021-04-18_19h49_17

📌 Docs at v4.6

I think docs at v4.6 is correct.
https://getbootstrap.com/docs/4.6/layout/grid/#how-it-works

The above example creates three equal-width columns on small, medium, large, and extra large devices using our predefined grid classes. Those columns are centered in the page with the parent .container.

PR

If this is an issue that needs to be fixed, I'd like to send a PR.

Thanks !

Environment

Operating system and version: Windows
Browser and version: Chrome 89.0.4389.114

@ffoodd
Copy link
Member

ffoodd commented Apr 18, 2021

I agree, this is a wrong assertion: either get the 4.6 docs sentence back or get rid off -sm suffix to make the sentence true. The latter would require to reword columns content (maybe something like "⅓ column").

@kohheepeace
Copy link
Contributor Author

I think it would be better to remove the sm prefix.

Because the following code is the simplest grid system example.

<div class="container">
  <div class="row">
    <div class="col">
    </div>
    ...
  </div>
</div>

It also makes sense to separate this "example" section from the "How it works" section in v5.0

@mdo
Copy link
Member

mdo commented Apr 19, 2021

Closed by #33676

@mdo mdo closed this as completed Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants