Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offcanvas.js: If scroll is allowed, should allow focus on other elements #33677

Merged
merged 2 commits into from Apr 20, 2021

Conversation

GeoSot
Copy link
Member

@GeoSot GeoSot commented Apr 18, 2021

This change does allow to focus on other elements while an offcanvas that allows body scroll, is open

Preview: https://deploy-preview-33677--twbs-bootstrap.netlify.app/docs/5.0/components/offcanvas/#backdrop

@GeoSot GeoSot requested a review from a team as a code owner April 18, 2021 21:14
@GeoSot GeoSot added this to Inbox in v5.0.0 via automation Apr 18, 2021
@XhmikosR XhmikosR moved this from Inbox to Review in v5.0.0 Apr 19, 2021
@GeoSot GeoSot force-pushed the gs-regression-allow-offcanvas-to-not-enforce-focus branch from affef84 to 7aa4a3c Compare April 19, 2021 15:42
v5.0.0 automation moved this from Review to Approved Apr 19, 2021
@XhmikosR XhmikosR merged commit 079f2cd into main Apr 20, 2021
v5.0.0 automation moved this from Approved to Done Apr 20, 2021
@XhmikosR XhmikosR deleted the gs-regression-allow-offcanvas-to-not-enforce-focus branch April 20, 2021 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v5.0.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants