Don't change the value for altBoundary option
#33684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Since bootstrap is not changing the default value of `elementContext` option, changing the value of `altBoundary` option is not needed for any modifier in real
|
I had a feeling this would be the reason but I wasn't sure still. 😅 I got a bit confused by what all those options really do and how they influence each other and what if you change it on one module but not on the other. |
alpadev
approved these changes
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #33463 and
Closes #33579
Since the bootstrap is not changing the default value of the
elementContextoption, changing the value of thealtBoundaryoption is not needed for any modifier in real. By default, the value forelementContextis'popper'which means the boundary context will be checked for the popper element by default. Setting thealtBoundaryto true in the flip modifier will change this behavior and then boundary context will be checked for reference element (means button element).Doing so will require setting the value for the
boundaryoption manually. That is not needed in real (at least for the tooltips when these are appended to the body).See the discussion here: #33463 (comment)
/CC @XhmikosR to add this in the next release if seems good.