Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix the default value of Popper's boundary option #33685

Merged
merged 4 commits into from Apr 21, 2021

Conversation

rohit2sharma95
Copy link
Collaborator

@rohit2sharma95 rohit2sharma95 commented Apr 19, 2021

Since 'scrollParent' is no longer the default value for the boundary option.

See: https://popper.js.org/docs/v2/utils/detect-overflow/#options

/CC @mdo to check the wording once 馃檪

Preview: https://deploy-preview-33685--twbs-bootstrap.netlify.app/docs/5.0/components/tooltips/#usage

- Since `'scrollParent'` is no longer the default value for the `boundary` option
@XhmikosR XhmikosR added this to Inbox in v5.0.0 via automation Apr 19, 2021
@XhmikosR XhmikosR requested a review from mdo April 19, 2021 17:11
@XhmikosR XhmikosR moved this from Inbox to Review in v5.0.0 Apr 20, 2021
@XhmikosR XhmikosR changed the title Update docs to change the default value for Popper Update docs to reflect the default value for Popper's boundary option Apr 20, 2021
@XhmikosR XhmikosR changed the title Update docs to reflect the default value for Popper's boundary option docs: fix the default value of Popper's boundary option Apr 20, 2021
v5.0.0 automation moved this from Review to Approved Apr 21, 2021
@XhmikosR XhmikosR merged commit 4d97325 into main Apr 21, 2021
v5.0.0 automation moved this from Approved to Done Apr 21, 2021
@XhmikosR XhmikosR deleted the rs/popper-default-config branch April 21, 2021 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.0.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants