Scrollbar: respect the initial body overflow value #33706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpadev
reviewed
Apr 20, 2021
GeoSot
force-pushed
the
gs-scrollbar-proper-handle-of-body-overflow
branch
from
3b5c604
to
71151d7
Compare
alpadev
reviewed
Apr 20, 2021
GeoSot
force-pushed
the
gs-scrollbar-proper-handle-of-body-overflow
branch
from
71151d7
to
6b73db4
Compare
rohit2sharma95
approved these changes
Apr 23, 2021
* add method to handle overflow on body element & tests * replace duplicated code on modal|offcanvas tests
GeoSot
force-pushed
the
gs-scrollbar-proper-handle-of-body-overflow
branch
from
6b73db4
to
6b7c538
Compare
XhmikosR
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: First Pr #33245 was to just decoupling scrollbar functionality form modal.js , coping the existing code as it was.
This PR: