Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accordion: fix border-top on Firefox #33736

Merged
merged 3 commits into from Apr 30, 2021
Merged

accordion: fix border-top on Firefox #33736

merged 3 commits into from Apr 30, 2021

Conversation

alpadev
Copy link
Contributor

@alpadev alpadev commented Apr 23, 2021 •
edited

fixes #33730

The difference is only visible when zoomed in (and in FF).

Preview: https://deploy-preview-33736--twbs-bootstrap.netlify.app/docs/5.0/components/accordion/

@alpadev alpadev requested a review from a team April 23, 2021 21:16
@XhmikosR XhmikosR added this to Inbox in v5.0.0 via automation Apr 25, 2021
@XhmikosR XhmikosR requested a review from mdo April 25, 2021 03:51
@XhmikosR
Copy link
Member

@mdo @ffoodd I added this in the v5.0.0 project because it was an issue we had for a long time :)

@XhmikosR XhmikosR requested a review from ffoodd April 25, 2021 03:53
@XhmikosR XhmikosR changed the title refactor: adapt border-top instead of negative margin according: fix border-top on Firefox Apr 25, 2021
@XhmikosR XhmikosR changed the title according: fix border-top on Firefox accordion: fix border-top on Firefox Apr 25, 2021
@XhmikosR XhmikosR changed the title accordion: fix border-top on Firefox accordion: fix border-top on Firefox Apr 25, 2021
@XhmikosR XhmikosR moved this from Inbox to Review in v5.0.0 Apr 25, 2021
@alpadev alpadev marked this pull request as ready for review April 26, 2021 18:10
ffoodd
ffoodd approved these changes Apr 30, 2021
View reviewed changes
Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

v5.0.0 automation moved this from Review to Approved Apr 30, 2021
@XhmikosR XhmikosR merged commit 7fe4e43 into twbs:main Apr 30, 2021
v5.0.0 automation moved this from Approved to Done Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffoodd ffoodd ffoodd approved these changes

@mdo mdo Awaiting requested review from mdo

Assignees
No one assigned
Labels
css v5
Projects
No open projects
v5.0.0
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accordion - "missing" borders in Firefox
3 participants
@alpadev @XhmikosR @ffoodd