Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve overall new examples' accessibility #33772

Merged
merged 2 commits into from Apr 29, 2021
Merged

Conversation

ffoodd
Copy link
Member

@ffoodd ffoodd commented Apr 27, 2021

Small tweaks caught by Pa11y on Boosted. Mostly:

  1. ensuring having main and h1 on each page,
  2. a few input missing a label,
  3. some redundant alt on img inside a link,
  4. contents not wrapped in a landmark.

I ignore some other errors since they're not applicable for such snippets IMHO (several banner roles instead of one, for example).

Non-whitespace diff: https://github.com/twbs/bootstrap/pull/33772/files?w=1

@ffoodd ffoodd requested a review from a team as a code owner April 27, 2021 12:00
@ffoodd ffoodd force-pushed the fod-main-a11y-examples branch 3 times, most recently from 0f34321 to cc68ee4 Compare April 27, 2021 12:07
@XhmikosR XhmikosR added this to Inbox in v5.0.0 via automation Apr 27, 2021
@XhmikosR XhmikosR moved this from Inbox to Review in v5.0.0 Apr 27, 2021
site/content/docs/5.0/examples/sidebars/index.html Outdated Show resolved Hide resolved
site/content/docs/5.0/examples/headers/index.html Outdated Show resolved Hide resolved
site/content/docs/5.0/examples/headers/index.html Outdated Show resolved Hide resolved
site/content/docs/5.0/examples/headers/index.html Outdated Show resolved Hide resolved
@patrickhlauke
Copy link
Member

Note that my requested changes (the addition of aria-current) are admittedly snuck in here - they're not new things added/done by this PR, but as I stumbled across them...would be good to sneak those in too. other than that this PR looks good to me.

v5.0.0 automation moved this from Review to Approved Apr 29, 2021
@XhmikosR XhmikosR merged commit 7bbf6d9 into main Apr 29, 2021
v5.0.0 automation moved this from Approved to Done Apr 29, 2021
@XhmikosR XhmikosR deleted the fod-main-a11y-examples branch April 29, 2021 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.0.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants