Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add utility classes for opacity #33781

Merged
merged 8 commits into from Jun 23, 2021
Merged

Add utility classes for opacity #33781

merged 8 commits into from Jun 23, 2021

Conversation

coharishreddy
Copy link
Contributor

@coharishreddy coharishreddy commented Apr 28, 2021 •
edited by XhmikosR

Fixes #33483

@coharishreddy coharishreddy requested a review from a team as a code owner April 28, 2021 02:31
@coharishreddy coharishreddy changed the title Add responsive utility classes for opacity Add utility classes for opacity Apr 28, 2021
mdo
mdo reviewed Apr 29, 2021
View reviewed changes
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you for this! Just a few tweaks :).

site/content/docs/5.0/utilities/opacity.md Outdated Show resolved Hide resolved
site/content/docs/5.0/utilities/opacity.md Outdated Show resolved Hide resolved
@mdo mdo added this to In progress in v5.1.0 via automation Apr 29, 2021
coharishreddy and others added 2 commits April 29, 2021 13:54
@coharishreddy @mdo
Update site/content/docs/5.0/utilities/opacity.md
a8e39a8 
Co-authored-by: Mark Otto <otto@github.com>
@coharishreddy @mdo
Update site/content/docs/5.0/utilities/opacity.md
64305cc 
Co-authored-by: Mark Otto <otto@github.com>
ffoodd
ffoodd approved these changes Apr 29, 2021
View reviewed changes
Copy link
Member

@ffoodd ffoodd left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, thanks 🙂

v5.1.0 automation moved this from In progress to Reviewer approved Apr 29, 2021
@tkrotoff
Copy link
Sponsor Contributor

There is a spelling mistake for this commit (responisve => responsive):

image

@ffoodd
Copy link
Member

ffoodd commented May 12, 2021 •
edited

Commits will be squashed for such feature, but thanks for reporting 🙂

@mdo mdo merged commit a816615 into twbs:main Jun 23, 2021
v5.1.0 automation moved this from Approved to Done Jun 23, 2021
marvin-hinkley-vortx pushed a commit to Vortx-Inc/bootstrap that referenced this pull request Aug 18, 2021
@coharishreddy @XhmikosR
@mdo @alpadev @marvin-hinkley-vortx
Add utility classes for opacity (twbs#33781)
fd315fa 
* Add responsive utility classes for opacity

- fix for twbs#33483

* remove responsive opacity utils as it has impact on bootstrap.css bundle size

* Update opacity.md

* Update site/content/docs/5.0/utilities/opacity.md

Co-authored-by: Mark Otto <otto@github.com>

* Update site/content/docs/5.0/utilities/opacity.md

Co-authored-by: Mark Otto <otto@github.com>

Co-authored-by: Harish <halodoc@ip-192-168-1-101.ap-southeast-1.compute.internal>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Co-authored-by: Mark Otto <otto@github.com>
Co-authored-by: Mark Otto <markd.otto@gmail.com>
Co-authored-by: alpadev <2838324+alpadev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo left review comments

@ffoodd ffoodd ffoodd approved these changes

@ammi1378 ammi1378 ammi1378 approved these changes

Assignees
No one assigned
Labels
css feature v5
Projects
No open projects
v5.1.0
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Opacity classes (.opacity-25 opacity-50 .opacity-75) don't work
7 participants
@coharishreddy @tkrotoff @ffoodd @mdo @ammi1378 @XhmikosR @alpadev