Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak toast docs #33810

Merged
merged 3 commits into from May 4, 2021
Merged

Tweak toast docs #33810

merged 3 commits into from May 4, 2021

Conversation

patrickhlauke
Copy link
Member

  • a few rewordings/tweaks
  • add info about toasts with focusable/actionable controls (shouldn't autohide them)

- a few rewordings/tweaks
- add info about toasts with focusable/actionable controls (shouldn't autohide them)
@patrickhlauke patrickhlauke added this to Inbox in v4.6.1 via automation May 2, 2021
@patrickhlauke patrickhlauke added this to Inbox in v5.0.0 via automation May 2, 2021
@patrickhlauke patrickhlauke requested review from mdo and ffoodd May 2, 2021 12:09
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple copy tweaks

site/content/docs/5.0/components/toasts.md Outdated Show resolved Hide resolved
site/content/docs/5.0/components/toasts.md Outdated Show resolved Hide resolved
v5.0.0 automation moved this from Inbox to Approved May 2, 2021
patrickhlauke and others added 2 commits May 2, 2021 18:06
Co-authored-by: Mark Otto <markd.otto@gmail.com>
Co-authored-by: Mark Otto <markd.otto@gmail.com>
@XhmikosR XhmikosR merged commit cb38744 into main May 4, 2021
v5.0.0 automation moved this from Approved to Done May 4, 2021
@XhmikosR XhmikosR deleted the patrichlauke-toast-docs-tweak branch May 4, 2021 12:37
@XhmikosR XhmikosR moved this from Inbox to Needs manual backport in v4.6.1 May 14, 2021
@XhmikosR XhmikosR removed this from Needs manual backport in v4.6.1 Oct 8, 2021
@XhmikosR
Copy link
Member

XhmikosR commented Oct 8, 2021

@patrickhlauke I'm going to remove this from the 4.6.1 project, but if you backport it we can include it.

@patrickhlauke patrickhlauke mentioned this pull request Jan 2, 2022
patrickhlauke added a commit that referenced this pull request Jan 2, 2022
- a few rewordings/tweaks
- add info about toasts with focusable/actionable controls (shouldn't autohide them)

manual backport of #33810
XhmikosR pushed a commit that referenced this pull request Jan 3, 2022
- a few rewordings/tweaks
- add info about toasts with focusable/actionable controls (shouldn't autohide them)

manual backport of #33810
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.0.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants