Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offcanvas can not be closed by clicking outside when backdrop is false #33905

Closed
rohit2sharma95 opened this issue May 9, 2021 · 3 comments
Closed
Labels

Comments

@rohit2sharma95
Copy link
Collaborator

While reviewing #33605, issue #33491 can not be reproduced because the behavior has been changed in #33545.

Issue:
If there is no backdrop with the offcanvas, It can not be closed by clicking outside since the click event is bound only with the backdrop.

Bug reports must include:

It can be closed in #33605 IMO.

/CC @GeoSot @rajesh2kumar96

@rohit2sharma95 rohit2sharma95 added js v5 regression p1 Critical, and inhibits core functionality labels May 9, 2021
@GeoSot
Copy link
Member

GeoSot commented May 9, 2021

It can be closed in #33605 IMO.

I agree

If there is no backdrop with the offcanvas, It can not be closed by clicking outside since the click event is bound only with the backdrop.

I don't think this is an issue, as it complicates the component behavior, but if it has support, I am ok with it

(IMO, it is a bit tricky to click on a visible element. and another element outside of your scope to be closed)

@rohit2sharma95
Copy link
Collaborator Author

I don't think this is an issue, as it complicates the component behavior

That can be discussed, @GeoSot. Since folks are already using this behavior, removing it in the stable release may not be a good idea 🙂

@rohit2sharma95 rohit2sharma95 removed p1 Critical, and inhibits core functionality regression labels May 12, 2021
@rohit2sharma95
Copy link
Collaborator Author

Closing in favor #33491. Since the discussion has been moved there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants