Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cheatsheet: fix JS errors in setActiveItem() #34011

Merged
merged 1 commit into from
May 18, 2021

Conversation

ffoodd
Copy link
Member

@ffoodd ffoodd commented May 17, 2021

Fixes #33958

Prevent default on submit buttons, and check for an item matching location hash before going on.


Preview: https://deploy-preview-34011--twbs-bootstrap.netlify.app/docs/5.0/examples/cheatsheet/

@ffoodd ffoodd requested a review from a team as a code owner May 17, 2021 14:41
Copy link
Contributor

@alpadev alpadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@XhmikosR XhmikosR added examples and removed docs labels May 18, 2021
@XhmikosR XhmikosR changed the title Cheatsheet: fix JS errors in setActiveItem() Cheatsheet: fix JS errors in setActiveItem() May 18, 2021
@XhmikosR XhmikosR merged commit 83bcc3c into main May 18, 2021
@XhmikosR XhmikosR deleted the main-fod-cheastheet-js-bugs branch May 18, 2021 05:31
marvin-hinkley-vortx pushed a commit to Vortx-Inc/bootstrap that referenced this pull request May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cheatsheet bug in Forms>Submit Button and Scrollspy Header
3 participants