Improve vnu-jar.js #34075
Merged
Improve vnu-jar.js #34075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* switch to `execFile` for the java version command * simplify our ignores and removed no longer needed ones * remove `--no-langdetect` since it doesn't seem to trigger any issues any more
alpadev
approved these changes
Jun 4, 2021
XhmikosR
moved this from Needs manual backport
to Cherry-picked/Manually backported
in v4.6.1
XhmikosR
added a commit
that referenced
this pull request
Jun 22, 2021
Improve and clean up vnu-jar.js
XhmikosR
added a commit
that referenced
this pull request
Jun 24, 2021
Improve and clean up vnu-jar.js
XhmikosR
added a commit
that referenced
this pull request
Jul 8, 2021
Improve and clean up vnu-jar.js
XhmikosR
added a commit
that referenced
this pull request
Jul 21, 2021
Improve and clean up vnu-jar.js
marvin-hinkley-vortx
pushed a commit
to Vortx-Inc/bootstrap
that referenced
this pull request
Aug 18, 2021
* switch to `execFile` for the java version command * simplify our ignores and removed no longer needed ones * remove `--no-langdetect` since it doesn't seem to trigger any issues any more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
execFilefor the java version command--no-langdetectsince it doesn't seem to trigger any issues any more