Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub SHA in BrowserStack build ID. #34077

Merged
merged 4 commits into from Aug 30, 2021
Merged

Add GitHub SHA in BrowserStack build ID. #34077

merged 4 commits into from Aug 30, 2021

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented May 22, 2021 •
edited

TODO:

  • Switch to the short hash

@XhmikosR XhmikosR added this to Inbox in v5.0.2 via automation May 22, 2021
vsn4ik
vsn4ik reviewed May 24, 2021
View reviewed changes
js/tests/karma.conf.js Outdated Show resolved Hide resolved
@GeoSot GeoSot moved this from Inbox to Review in v5.0.2 Jun 4, 2021
@XhmikosR XhmikosR changed the title Add GitHub sha in BrowserStack build ID. Add GitHub SHA in BrowserStack build ID. Jun 13, 2021
@XhmikosR XhmikosR removed this from Review in v5.0.2 Jun 13, 2021
@XhmikosR XhmikosR added this to Inbox in v5.1.0 via automation Jun 13, 2021
@mdo mdo removed this from Inbox in v5.1.0 Aug 4, 2021
@mdo mdo added this to In progress in v5.1.1 via automation Aug 4, 2021
v5.1.1 automation moved this from In progress to Reviewer approved Aug 30, 2021
@XhmikosR XhmikosR marked this pull request as ready for review August 30, 2021 13:30
@XhmikosR XhmikosR requested a review from a team as a code owner August 30, 2021 13:30
@XhmikosR XhmikosR merged commit a7e64b5 into main Aug 30, 2021
v5.1.1 automation moved this from Reviewer approved to Done Aug 30, 2021
@XhmikosR XhmikosR deleted the main-xmr-browserstack-sha branch August 30, 2021 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsn4ik vsn4ik vsn4ik left review comments

@GeoSot GeoSot GeoSot approved these changes

Assignees
No one assigned
Labels
tests v5
Projects
No open projects
v5.1.1
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@XhmikosR @vsn4ik @GeoSot