img in horizontal card #34160
Merged
img in horizontal card #34160
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #34145 Simply adds `img-fluid` and `rounded-start` classes to horizontal card example to ensure copy-pasting from the docs matches the expectation.
This comment has been minimized.
This comment has been minimized.
|
hey @ffoodd we can simply add |
|
Which is probably not the expected result, in that case having rounded corners on the right looks weird IMHO. |
Yes you are right @ffoodd Thanks man for considering the issue. |
mdo
reviewed
Jun 2, 2021
mdo
approved these changes
Jun 2, 2021
mdo
approved these changes
Jun 3, 2021
marvin-hinkley-vortx
pushed a commit
to Vortx-Inc/bootstrap
that referenced
this pull request
Aug 18, 2021
* docs(cards): img in horizontal card Closes twbs#34145 Simply adds `img-fluid` and `rounded-start` classes to horizontal card example to ensure copy-pasting from the docs matches the expectation. * Update site/content/docs/5.0/components/card.md Co-authored-by: Mark Otto <markd.otto@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #34145
Simply adds
img-fluidandrounded-startclasses to horizontal card example to ensure copy-pasting from the docs matches the expectation.Preview: https://deploy-preview-34159--twbs-bootstrap.netlify.app/docs/4.6/getting-started/theming/#theme-colors