Skip to content

Cleanup tooltip & popover components #34205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 22, 2021
Merged

Cleanup tooltip & popover components #34205

merged 6 commits into from
Jul 22, 2021
+43 −78

Conversation

GeoSot
Copy link
Member

@GeoSot GeoSot commented Jun 8, 2021 •
edited
Loading

Do some cleanup on tooltip and popover

  • refactor duplicated code to functions
  • use newest methods

NOTE for reviewers:

Better review it, commit by commit. It will help you with the proper message and will guide you with sanity to follow the logic

preview

@GeoSot GeoSot force-pushed the gs-tooltip-cleanup branch from d65d1cb to fd3a7c5 Compare June 8, 2021 00:12
@GeoSot GeoSot marked this pull request as ready for review June 8, 2021 00:17
@GeoSot GeoSot requested a review from a team as a code owner June 8, 2021 00:17
@GeoSot GeoSot force-pushed the gs-tooltip-cleanup branch from 3073b41 to 0ad584f Compare June 10, 2021 08:05
@GeoSot GeoSot force-pushed the gs-tooltip-cleanup branch 3 times, most recently from 7df354c to 1bee4a9 Compare June 22, 2021 20:05
@GeoSot GeoSot requested review from rohit2sharma95 and alpadev June 23, 2021 08:24
rohit2sharma95
rohit2sharma95 reviewed Jun 23, 2021
View reviewed changes
@GeoSot GeoSot force-pushed the gs-tooltip-cleanup branch from e782183 to 111d6b3 Compare June 23, 2021 23:27
@GeoSot GeoSot requested a review from rohit2sharma95 June 28, 2021 12:16
@GeoSot GeoSot force-pushed the gs-tooltip-cleanup branch from 111d6b3 to 99203d0 Compare June 30, 2021 00:09
rohit2sharma95
rohit2sharma95 approved these changes Jul 5, 2021
View reviewed changes
Copy link
Contributor

@rohit2sharma95 rohit2sharma95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Better to have one more review from @twbs/js-review as I am very low at regex 😁

@GeoSot GeoSot force-pushed the gs-tooltip-cleanup branch 2 times, most recently from b191c69 to 7192509 Compare July 9, 2021 13:02
@GeoSot GeoSot changed the title Some cleanup on tooltip && popover Some cleanup on tooltip & popover Jul 9, 2021
@GeoSot GeoSot requested a review from ffoodd July 12, 2021 14:43
@GeoSot GeoSot mentioned this pull request Jul 16, 2021
Merged
3 tasks
@GeoSot GeoSot force-pushed the gs-tooltip-cleanup branch from 7192509 to 1a67c68 Compare July 19, 2021 15:55
XhmikosR
XhmikosR reviewed Jul 20, 2021
View reviewed changes
@GeoSot GeoSot force-pushed the gs-tooltip-cleanup branch 2 times, most recently from 63f15f8 to 9dc1cb3 Compare July 20, 2021 15:58
@XhmikosR XhmikosR force-pushed the gs-tooltip-cleanup branch from 9dc1cb3 to 0bf7d82 Compare July 20, 2021 15:59
@GeoSot GeoSot force-pushed the gs-tooltip-cleanup branch from 0bf7d82 to e6b3496 Compare July 20, 2021 16:14
@GeoSot
use a class private getter to decouple same methods usage

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
bf7691e
@GeoSot GeoSot force-pushed the gs-tooltip-cleanup branch from e6b3496 to cd09250 Compare July 22, 2021 13:36
@XhmikosR XhmikosR force-pushed the gs-tooltip-cleanup branch 3 times, most recently from ae54c4f to 865f918 Compare July 22, 2021 13:51
@XhmikosR XhmikosR changed the title Some cleanup on tooltip & popover Cleanup tooltip & popover components Jul 22, 2021
@XhmikosR XhmikosR force-pushed the gs-tooltip-cleanup branch from 865f918 to ca5ef81 Compare July 22, 2021 14:04
@XhmikosR XhmikosR merged commit da2db21 into main Jul 22, 2021
@XhmikosR XhmikosR deleted the gs-tooltip-cleanup branch July 22, 2021 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@folknor folknor

@XhmikosR XhmikosR

@rohit2sharma95 rohit2sharma95

@alpadev alpadev

@ffoodd ffoodd

Assignees
No one assigned
Labels
js no squash refactoring v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@GeoSot @folknor @XhmikosR @rohit2sharma95