Make proper use of the SelectorEngine in ScrollSpy #34207
Merged
+8
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoSot
force-pushed
the
gs-scrollspy-use-selector_engine-properly
branch
from
6d8d493 to
c9dbdad
Compare
GeoSot
changed the title
GeoSot
force-pushed
the
gs-scrollspy-use-selector_engine-properly
branch
from
c9dbdad to
34ce061
Compare
alpadev
approved these changes
Jun 19, 2021
* avoid extra work, creating ids * simplify selectors and constrain search inside `config.target`
GeoSot
force-pushed
the
gs-scrollspy-use-selector_engine-properly
branch
from
34ce061 to
b60faa9
Compare
XhmikosR
reviewed
Jun 23, 2021
| @@ -150,15 +149,7 @@ class ScrollSpy extends BaseComponent { | |||
| ...(typeof config === 'object' && config ? config : {}) | |||
| } | |||
|
|
|||
| if (typeof config.target !== 'string' && isElement(config.target)) { | |||
There was a problem hiding this comment.
Are you sure this wasn't needed? IIRC it was used to make sure the IDs are unique or something.
There was a problem hiding this comment.
It was used to make string selectors, But wasn't using the Selector engine scoped search.
I replaced the search to be done on element scope, so we keep the element as reference, not the id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
config.target