Use the switch statement instead of if
#34215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohit2sharma95
force-pushed
the
rs/build-plugins-warning
branch
from
bfe18e8
to
997900f
Compare
GeoSot
reviewed
Jun 9, 2021
|
The re-write is ok. However I am not sure, if this file is mirroring the latest picture of our components. Is there any case where we could read the "imports" during the build? It would be safer to create them dynamically |
|
@GeoSot It's possible to use functions for |
|
I'd land this and then see if we can make this more robust. Also, we might need to backport any changes manually to v4-dev. |
GeoSot
approved these changes
Jun 22, 2021
|
@rohit2sharma95 can you please backport it and make a PR? |
|
@XhmikosR Seems that this PR is not that much required to be backported as there are only two checks in the v4-dev branch 🤔 |
|
NP, I'll remove it from backporting :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the warning about the complexity of the arrow function (by reducing the number of lines in that function) in the
build-plugins.jsfile.See warning here: https://github.com/twbs/bootstrap/runs/2770771101#step:6:41