Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carousel controls broken in main #34226

Closed
jonnysp opened this issue Jun 10, 2021 · 5 comments · Fixed by #34266
Closed

Carousel controls broken in main #34226

jonnysp opened this issue Jun 10, 2021 · 5 comments · Fixed by #34266
Labels
js p1 Critical, and inhibits core functionality v5
Projects
v5.0.2

Comments

@jonnysp
Copy link
Contributor

jonnysp commented Jun 10, 2021

currently the carousel prev and next buttons not working, the indicators are working.

can anyone confirm this problem?

https://jsfiddle.net/jonnysp/dfz3x7at/
@mdo
Copy link
Member

mdo commented Jun 11, 2021

I cannot open your JS Fiddle for some reason, but everything seems to work fine here: https://getbootstrap.com/docs/5.0/components/carousel/.

@mdo mdo closed this as completed Jun 11, 2021
@jonnysp
Copy link
Contributor Author

jonnysp commented Jun 13, 2021

@mdo
not the actual release. checkout the latest main branch, compile and try.

@tungphan995

This comment has been minimized.

Sign in to view
@alpadev alpadev reopened this Jun 15, 2021
@alpadev
Copy link
Contributor

alpadev commented Jun 15, 2021

The issue is actually valid 😥
Looks like #33276 broke it. See https://deploy-preview-33276--twbs-bootstrap.netlify.app/docs/5.0/components/carousel/#with-captions

@mdo mdo added this to Inbox in v5.0.2 via automation Jun 16, 2021
@mdo mdo changed the title Carusell Buttons not working Carousel controls broken in main Jun 16, 2021
@mdo
Copy link
Member

mdo commented Jun 16, 2021

Ah yes, I see it now. /cc @GeoSot as the PR author

I think we either patch that PR or revert it so we can ship v5.0.2 later this week. Up to you, @alpadev @GeoSot et al.

@alpadev alpadev mentioned this issue Jun 16, 2021
Merged
@alpadev alpadev added the p1 Critical, and inhibits core functionality label Jun 16, 2021
v5.0.2 automation moved this from Inbox to Done Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
js p1 Critical, and inhibits core functionality v5
Projects
No open projects
v5.0.2
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix carousel buttons twbs/bootstrap
4 participants
@mdo @jonnysp @alpadev @tungphan995