Skip to content

Make the $accordion-icon-color default value consistent with the $accordion-button-color #34481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 26, 2021
Merged

Make the $accordion-icon-color default value consistent with the $accordion-button-color #34481

merged 3 commits into from
Jul 26, 2021

Conversation

TheFakeCake
Copy link
Contributor

This PR changes the default value of the $accordion-icon-color variable to match $accordion-button-color.

Since the icon is part of the button, when customizing the accordion button color, the icon should have the same color by default.

Change the $accordion-icon-color variable default value to
$accordion-button-color
@TheFakeCake TheFakeCake requested a review from a team as a code owner July 12, 2021 13:07

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically fine. @mdo your call regarding the design decision, both make sense to me.

@XhmikosR XhmikosR requested a review from mdo July 21, 2021 16:16

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@mdo mdo merged commit 9ef7ca5 into twbs:main Jul 26, 2021
@XhmikosR XhmikosR changed the title Make the $accordion-icon-color default value consistent with the $accordion-button-color Make the $accordion-icon-color default value consistent with the $accordion-button-color Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants