Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nav-tab.md #34517

Merged
merged 2 commits into from
Jul 26, 2021
Merged

Update nav-tab.md #34517

merged 2 commits into from
Jul 26, 2021

Conversation

jitangupta
Copy link
Contributor

Updated the anchor tag with button in sample examples

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Updated the from anchor tag to button in sample examples
@XhmikosR
Copy link
Member

@mdo @ffoodd: we use both a and buttons in the markup examples, are you sure it makes sense to change the JS API examples?

@ffoodd
Copy link
Member

ffoodd commented Jul 19, 2021

I'd recommend to always use buttons for tabs, so yes. Might we replace as with buttons everywhere, too?

@XhmikosR
Copy link
Member

I'd just change this patch to indicate that both can be used for now using a JS comment, since both markups are allowed.

@mdo
Copy link
Member

mdo commented Jul 26, 2021

Going to merge as-is and we can iterate on this further with additional PRs.

@mdo mdo merged commit e805a5e into twbs:main Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants