Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tooltip data-bs-original-title issue #34842

Merged
merged 2 commits into from Aug 31, 2021

Conversation

GeoSot
Copy link
Member

@GeoSot GeoSot commented Aug 30, 2021

Bring back the tricky way to update title

Suggest to NOT USE it as it is for internal usage and probably will change
closes #34736

@GeoSot GeoSot force-pushed the gs/regression-tooltip-tricky-changes-title branch from aa40d44 to d904322 Compare August 31, 2021 08:08
@GeoSot GeoSot added this to In progress in v5.1.1 via automation Aug 31, 2021
@GeoSot GeoSot marked this pull request as ready for review August 31, 2021 08:20
@GeoSot GeoSot requested a review from a team as a code owner August 31, 2021 08:20
@GeoSot GeoSot moved this from In progress to Review in progress in v5.1.1 Aug 31, 2021
@GeoSot GeoSot force-pushed the gs/regression-tooltip-tricky-changes-title branch from d904322 to 423a67f Compare August 31, 2021 08:26
v5.1.1 automation moved this from Review in progress to Reviewer approved Aug 31, 2021
@XhmikosR XhmikosR changed the title Regression on tooltip tricky title change Fix tooltip data-bs-original-title issue Aug 31, 2021
@XhmikosR XhmikosR merged commit 51afe02 into main Aug 31, 2021
v5.1.1 automation moved this from Reviewer approved to Done Aug 31, 2021
@XhmikosR XhmikosR deleted the gs/regression-tooltip-tricky-changes-title branch August 31, 2021 13:11
@tdaniely-dn
Copy link

tdaniely-dn commented May 4, 2022

innerHTML can return escaped version of the title in some cases, not clear when. Same code works in jsfiddle.
Should be textContent I think.
Got this doing customizations inside jenkins gui.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.1.1
  
Done
Development

Successfully merging this pull request may close these issues.

Regression in Tooltip: content doesn't update after first show
3 participants