Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: make use of the .Site.Params.docs_version variable #34913

Merged
merged 3 commits into from Sep 6, 2021

Conversation

julien-deramond
Copy link
Member

This PR is a proposal to use the .Site.Params.docs_version to display the latest version in the versions selector to avoid having 5.0.x instead of 5.1.x:

Capture d’écran 2021-09-06 à 17 41 50

Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems appropriate!

@XhmikosR XhmikosR added this to Inbox in v4.6.1 via automation Sep 6, 2021
@XhmikosR XhmikosR moved this from Inbox to Needs manual backport in v4.6.1 Sep 6, 2021
@XhmikosR XhmikosR changed the title Automatically retrieve latest Bootstrap version in versions selector docs: make use of the .Site.Params.docs_version variable Sep 6, 2021
@XhmikosR XhmikosR merged commit 16aab88 into twbs:main Sep 6, 2021
@XhmikosR XhmikosR added this to In progress in v5.1.1 via automation Sep 6, 2021
@XhmikosR XhmikosR moved this from In progress to Done in v5.1.1 Sep 6, 2021
@XhmikosR XhmikosR moved this from Needs manual backport to Cherry-picked/Manually backported in v4.6.1 Sep 8, 2021
@XhmikosR XhmikosR moved this from Cherry-picked/Manually backported to Shipped in v4.6.1 Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v4.6.1
Shipped
v5.1.1
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants