Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Collapse regression of handling toggling between sibling chilldren #34951

Merged
merged 2 commits into from
Sep 15, 2021
Merged

Fix Collapse regression of handling toggling between sibling chilldren #34951

merged 2 commits into from
Sep 15, 2021
+60 −2

Conversation

GeoSot
Copy link
Member

@GeoSot GeoSot commented Sep 10, 2021

Fixes #34850

@GeoSot GeoSot requested a review from a team as a code owner September 10, 2021 23:15
@XhmikosR XhmikosR changed the title Regression on Collapse, to proper handle toggling between sibling chilldren Fix Collapse regression of handling toggling between sibling chilldren Sep 11, 2021
@XhmikosR XhmikosR added the p1 Critical, and inhibits core functionality label Sep 11, 2021
@XhmikosR
Merge branch 'main' into gs/handle-collapse-children-toggle

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
8537a9b
@XhmikosR XhmikosR merged commit bdfb4cc into main Sep 15, 2021
@XhmikosR XhmikosR deleted the gs/handle-collapse-children-toggle branch September 15, 2021 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XhmikosR XhmikosR

Assignees
No one assigned
Labels
js p1 Critical, and inhibits core functionality regression v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Collapse Parent Grouping does not work inside a parent container with a "collapse" class
2 participants
@GeoSot @XhmikosR