Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a scss file that contains only copyright banner for cherry-picking imports #35205

Closed
2 tasks done
ntkme opened this issue Oct 15, 2021 · 8 comments
Closed
2 tasks done

Comments

@ntkme
Copy link
Contributor

ntkme commented Oct 15, 2021

Prerequisites

Proposal

Add a banner.scss (or maybe name it copyright.scss or license.scss to avoid confusion) that only contains the copyright information for cherry-picking imports with copyright information.

Motivation and context

I have projects that are cherry-picking a only few scss files from bootstrap to be imported.

I want to properly include the bootstrap copyright header but there is no easy way to do so right now other than manual copy-paste the copyright banner.

@ntkme ntkme added the feature label Oct 15, 2021
@ntkme ntkme changed the title Suggest a new feature Add a scss file that contains only copyright banner for cherry-picking imports Oct 15, 2021
@WinterSilence
Copy link
Contributor

WinterSilence commented Oct 15, 2021

@ntkme comment unusable files(// ...) in bootstrap.scss and run npm run dist

https://getbootstrap.com/docs/5.1/getting-started/contribute/

@ntkme
Copy link
Contributor Author

ntkme commented Oct 15, 2021

@WinterSilence I'm directly importing files from node_modules/bootstrap/sass/... so that won't work.

@WinterSilence
Copy link
Contributor

@ntkme
Copy link
Contributor Author

ntkme commented Oct 15, 2021

@WinterSilence That won't show a copyright comment in the result css file. Also this is for a pure CSS project, there is no JS bundler anyways.

@WinterSilence
Copy link
Contributor

@ntkme that's script generate summary comment - you can use it anywhere. "pure CSS project" still use python/ruby for compile scss

@ntkme
Copy link
Contributor Author

ntkme commented Oct 15, 2021

@WinterSilence You cannot import a JS file when scss are compiled using ruby's sassc gem or sass-embedded gem, because they are just scss compilers, but not bundlers like webpack or rollup. There is no way to cross import/reference JS/SCSS in such simple setup.

@WinterSilence
Copy link
Contributor

@ntkme I'm not against your suggestion. I'm talking about how to get a similar result now.

@ntkme
Copy link
Contributor Author

ntkme commented Jul 13, 2022

Done with #36178.

@ntkme ntkme closed this as completed Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants