Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate text to prevent multiline floating label #36327

Merged
merged 1 commit into from May 21, 2022

Conversation

HDPham
Copy link
Contributor

@HDPham HDPham commented May 11, 2022

Add css properties to label that will truncate long texts to prevent multi-line floating texts

Addresses #36270

@HDPham HDPham requested a review from a team as a code owner May 11, 2022 05:10
@mdo mdo force-pushed the truncate-floating-labels branch from 608a7d3 to 8959708 Compare May 11, 2022 18:30
@mdo mdo added this to In progress in v5.2.0-stable via automation May 11, 2022
@mdo mdo force-pushed the truncate-floating-labels branch from 8959708 to 22821f2 Compare May 20, 2022 23:58
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

v5.2.0-stable automation moved this from In progress to Reviewer approved May 21, 2022
@mdo mdo force-pushed the truncate-floating-labels branch from 22821f2 to 50dc80b Compare May 21, 2022 17:43
@mdo mdo merged commit 7ed1a5f into twbs:main May 21, 2022
v5.2.0-stable automation moved this from Reviewer approved to Done May 21, 2022
terencehonles added a commit to terencehonles/bootstrap that referenced this pull request Jul 8, 2022
This change allows the floating label to expand its width as it's scaled
down because the `width: 100%` as defined in
twbs#36327 will no longer be correct.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.2.0-stable
  
Done
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants