Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add the version in npm/yarn commands #36345

Merged
merged 2 commits into from May 13, 2022
Merged

docs: add the version in npm/yarn commands #36345

merged 2 commits into from May 13, 2022

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented May 13, 2022 •
edited

I don't love it but we are consistent for the time being. We could/should revisit this later.

@XhmikosR XhmikosR requested a review from mdo May 13, 2022 16:56
@XhmikosR XhmikosR added this to In progress in v5.2.0 via automation May 13, 2022
@XhmikosR XhmikosR marked this pull request as ready for review May 13, 2022 17:15
@XhmikosR XhmikosR requested a review from a team as a code owner May 13, 2022 17:15
v5.2.0 automation moved this from In progress to Reviewer approved May 13, 2022
@XhmikosR XhmikosR merged commit 46bb9e7 into main May 13, 2022
v5.2.0 automation moved this from Reviewer approved to Done May 13, 2022
@XhmikosR XhmikosR deleted the docs-npm branch May 13, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

Assignees
No one assigned
Labels
docs v5
Projects
No open projects
v5.2.0
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@XhmikosR @mdo