Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: improve image compression #36346

Merged
merged 1 commit into from May 25, 2022
Merged

Docs: improve image compression #36346

merged 1 commit into from May 25, 2022

Conversation

XhmikosR
Copy link
Member

No description provided.

@julien-deramond
Copy link
Member

julien-deramond commented May 22, 2022

FYI there are new images in /docs/5.2/assets/img/guides since you've created this PR; and some new will be added as well with the rewriting of Parcel guide and the new Vite guide. IDK if their compression needs to be improved the way you did it here.

Just out of curiosity what's been used to improve the image compression here?

@XhmikosR
Copy link
Member Author

Every image should be compressed before it lands. It seems the new images you mentioned weren't compressed.

There are numerous ways to do this. I'm using my custom scripts which mostly work on Windows.

As a first good step you should use something like https://kraken.io/web-interface (lossy since these aren't landmarks). Then you can ping me to improve compression further.

I'll update the branch with the current images.

@XhmikosR XhmikosR force-pushed the xmr/docs-img-compress branch 2 times, most recently from 7672c96 to 8c56e47 Compare May 23, 2022 06:12
@XhmikosR XhmikosR changed the title Docs: slightly improve image compression Docs: improve image compression May 23, 2022
@XhmikosR XhmikosR force-pushed the xmr/docs-img-compress branch 2 times, most recently from b751075 to 5b4f849 Compare May 23, 2022 07:41
@XhmikosR XhmikosR marked this pull request as ready for review May 23, 2022 10:29
@XhmikosR XhmikosR added this to In progress in v5.2.0-stable via automation May 23, 2022
v5.2.0-stable automation moved this from In progress to Reviewer approved May 25, 2022
@XhmikosR XhmikosR merged commit 0c5cc1b into main May 25, 2022
v5.2.0-stable automation moved this from Reviewer approved to Done May 25, 2022
@XhmikosR XhmikosR deleted the xmr/docs-img-compress branch May 25, 2022 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.2.0-stable
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants