add back focus box shadow to btn-link
#36366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5.2.0-beta1 looks to have accidentally dropped the box shadow around
btn-linkbuttons on focus. You can see this by tab navigating to abtn-linkon both 5.1.x and 5.2.0-beta1 and comparingThis is because the
--#{$prefix}btn-focus-shadow-rgbvariable is undefined in the context ofbtn-link. My solution here does involve code duplication from thebutton-variant()mixin - I'm certainly open to other solutions, however this illustrates the problem and a potential solution.Preview link: https://deploy-preview-36366--twbs-bootstrap.netlify.app/docs/5.2/components/buttons/#examples