Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite Webpack guide #36382

Merged
merged 3 commits into from May 20, 2022
Merged

Rewrite Webpack guide #36382

merged 3 commits into from May 20, 2022

Conversation

mdo
Copy link
Member

@mdo mdo commented May 17, 2022

This rewrites the entire Webpack guide to be an actual guide. One lingering question I have is if we need to include a section here for how to import only parts of Bootstrap instead of kicking that to the live example. I might swing back around and add that as well, but for now, would love some feedback.

The gist of this is available in a new examples repo over at https://github.com/twbs/examples/tree/main/webpack. So far everything looks and works as intended, including some JS and Popper, for me locally and in Stackblitz.

/cc @GeoSot

preview: https://deploy-preview-36382--twbs-bootstrap.netlify.app/docs/5.2/getting-started/webpack/

@mdo mdo requested a review from a team as a code owner May 17, 2022 16:36
@mdo mdo added this to In progress in v5.2.0-stable via automation May 17, 2022
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really like the new tutorial approach of this page following the spirit of the new "Quick start" in 5.2.
My only concern would be about the maintenance but I suppose that the community will report some issues if it doesn't work exactly the same in the future :)

site/content/docs/5.2/getting-started/webpack.md Outdated Show resolved Hide resolved
site/content/docs/5.2/getting-started/webpack.md Outdated Show resolved Hide resolved
site/content/docs/5.2/getting-started/webpack.md Outdated Show resolved Hide resolved
site/content/docs/5.2/getting-started/webpack.md Outdated Show resolved Hide resolved
site/content/docs/5.2/getting-started/webpack.md Outdated Show resolved Hide resolved
site/content/docs/5.2/getting-started/webpack.md Outdated Show resolved Hide resolved
site/content/docs/5.2/getting-started/webpack.md Outdated Show resolved Hide resolved
site/content/docs/5.2/getting-started/webpack.md Outdated Show resolved Hide resolved
site/content/docs/5.2/getting-started/webpack.md Outdated Show resolved Hide resolved
@GeoSot GeoSot marked this pull request as draft May 17, 2022 22:35
@mdo mdo marked this pull request as ready for review May 18, 2022 04:10
v5.2.0-stable automation moved this from In progress to Reviewer approved May 18, 2022
@julien-deramond
Copy link
Member

Would it be interesting to create a guide for Vite? People seems to be hyped by Vite which is pretty high in https://2021.stateofjs.com/en-US/libraries/build-tools as well.

mdo and others added 2 commits May 20, 2022 11:31
Co-Authored-By: GeoSot <geo.sotis@gmail.com>
Co-Authored-By: Julien Déramond <17381666+julien-deramond@users.noreply.github.com>
@mdo mdo merged commit 3a327c9 into main May 20, 2022
v5.2.0-stable automation moved this from Reviewer approved to Done May 20, 2022
@mdo mdo deleted the new-webpack-guide branch May 20, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.2.0-stable
  
Done
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants