JS: tests fixes & standardization of spies usage #36398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you split the first two patches into two separate PRs please? |
louismaximepiton
force-pushed
the
main-lmp-js-fixes
branch
from
505175a
to
26a6274
Compare
|
Done, I think this was the separation you wanted ? spec/js. The new PR is #36440. |
|
Thank you a lot @louismaximepiton |
GeoSot
approved these changes
May 31, 2022
GeoSot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the issues concerning the CSS part, we encountered with @julien-deramond.
The commits can be splited if needed or wanted or even be in another PR. I'm open to every comment that could help fix these issues.
Tackled by the PR:
Typo with (5b133f5)
Carousel test typo error with
maybeEnableCycle.Test improvement with (41c228b)
Carousel test since the test looked weird to me (Calling the function and expected to be called)
Spy declaration with (505175a)
Make the spy declaration almost the same everywhere to be more consistent. Not sure if this is mandatory.