Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Modal dismiss handler, listening to key down, instead of click #36401

Merged
merged 1 commit into from Jun 21, 2022

Conversation

GeoSot
Copy link
Member

@GeoSot GeoSot commented May 19, 2022

closes #36394

ref: #36324, #36603

@GeoSot GeoSot added this to In progress in v5.2.0-stable via automation May 19, 2022
@GeoSot GeoSot force-pushed the gs/fix-modal-false-dismissal branch from 0d8013f to 8ffb076 Compare May 31, 2022 08:02
@GeoSot GeoSot marked this pull request as ready for review June 8, 2022 12:00
@GeoSot GeoSot requested a review from a team as a code owner June 8, 2022 12:00
@GeoSot GeoSot force-pushed the gs/fix-modal-false-dismissal branch from 8ffb076 to 169c12e Compare June 8, 2022 12:02
v5.2.0-stable automation moved this from In progress to Reviewer approved Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.2.0-stable
  
Done
Status: Done
Development

Successfully merging this pull request may close these issues.

v5.2 Modal hides if selecting text and dragging off the modal
2 participants