CSS: few proposals #36406
Merged
CSS: few proposals #36406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the issues concerning the CSS part, we encountered with @julien-deramond.
The commits can be splited if needed or wanted or even be in another PR. I'm open to every comment that could help fix these issues.
Tackled by the PR:
!importantwith (ca48cc8)This PR adds a check for important utilities. It doesn't change anything on Bootstrap side, but might be useful for people that don't want
!importantin their code. If this commit is approved, it might lead to refactor some helpers' scss files.Border-*-0with (adc78d0)This PR tries to make the
.border-*-0utility more understandable. It could be useful too, since the Stackblitz example doesn't take into account the examples' classes.Rounded numbers with (dee2d26)
Having a rounded number of pixels for people that use
1rem = 16px.