Rewrite Parcel guide #36411
Merged
Rewrite Parcel guide #36411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mdo
commented
May 20, 2022
•
mdo
commented
- Needs images
- Consider adding extra CSS and JS import options
13 tasks
There was a problem hiding this comment.
Followed the guide without any issues :) Good job here!
Got a general feedback based on the comparison of Webpack and Parcel guides:
- In Webpack we have "Project structure" and "Configure Webpack". Here we only have "Project structure". Maybe you could introduce as well "Configure Parcel" section even if there's no such thing as
parcel.config.jsto configure. - In the same spirit, we fill the
index.htmlfile and then thepackage.jsonin the Webpack guide and those sections are inverted here.
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
approved these changes
May 22, 2022
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.