Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Remove .is-invalid from textarea validation example #36417

Merged
merged 1 commit into from May 21, 2022
Merged

Docs: Remove .is-invalid from textarea validation example #36417

merged 1 commit into from May 21, 2022

Conversation

wxh06
Copy link
Contributor

@wxh06 wxh06 commented May 21, 2022

https://getbootstrap.com/docs/5.2/forms/validation/#supported-elements

I'm not sure whether the CSS class .is-invalid has been added on purpose or not, but the incorrectly remaining invalid-feedback really confused me when I saw it for the first time until I inspected the source code.

Before After
截屏2022-05-21 15.20.06.png 截屏2022-05-21 15.19.15.png

@mdo mdo added this to In progress in v5.2.0-stable via automation May 21, 2022
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good eyes, that shouldn't be there :).

v5.2.0-stable automation moved this from In progress to Reviewer approved May 21, 2022
@mdo mdo merged commit 8d87997 into twbs:main May 21, 2022
v5.2.0-stable automation moved this from Reviewer approved to Done May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.2.0-stable
  
Done
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants