Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stylelint: Disable custom-property-empty-line-before #36423

Merged
merged 1 commit into from May 23, 2022

Conversation

mdo
Copy link
Member

@mdo mdo commented May 23, 2022

Cleans up a ton of CSS comments where we've disabled the rule.

@mdo mdo requested a review from a team as a code owner May 23, 2022 02:25
@mdo mdo added this to In progress in v5.2.0-stable via automation May 23, 2022
@mdo mdo merged commit 427c089 into main May 23, 2022
v5.2.0-stable automation moved this from In progress to Done May 23, 2022
@mdo mdo deleted the update-stylelint-css-vars branch May 23, 2022 02:58
@XhmikosR
Copy link
Member

@mdo should this land upstream in our config? If so can you make a PR there please?

@XhmikosR
Copy link
Member

Confirmed, this change breaks upstream CI https://github.com/twbs/stylelint-config-twbs-bootstrap/runs/6567960032?check_suite_focus=true

I'll make an upstream patch and release a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v5.2.0-stable
  
Done
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants