Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS: doc fixes #36425

Merged
merged 4 commits into from May 24, 2022
Merged

CSS: doc fixes #36425

merged 4 commits into from May 24, 2022

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented May 23, 2022

Implementing some @julien-deramond remarks.

PR content:

Unused attributes (5e92c4c)

Since the .bi gives some attributes to the svg in doc, I removed the unused ones that couldn't be there.

Use utilities (46c8a9a)

Instead of adding some new CSS rules, use the utilities mt-0 me-0

Unused class (5cf10f2)

Removed .masthead-followup-svg that is no longer used in Bootstrap.

StackBlitz (a96d843)

Reajust the aria-label of the StackBlitz button + removed space

@louismaximepiton louismaximepiton marked this pull request as ready for review May 23, 2022 12:57
@louismaximepiton louismaximepiton requested review from a team as code owners May 23, 2022 12:57
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mdo mdo merged commit dea14df into twbs:main May 24, 2022
@mdo mdo added this to In progress in v5.2.0-stable via automation May 24, 2022
@mdo mdo moved this from In progress to Done in v5.2.0-stable May 24, 2022
@louismaximepiton louismaximepiton deleted the main-lmp-jd-css-fixes branch September 2, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.2.0-stable
  
Done
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants