Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-ordering js default objects #36440

Merged
merged 1 commit into from Jun 2, 2022

Conversation

louismaximepiton
Copy link
Member

Here are the issues concerning the CSS part, we encountered with @julien-deramond.

This PR is a split of #36398

Tackled by the PR

Re-order for default objects with (633fca4)

Alphabetical reordering of the default objects. If these changes are approved, it might be great to see if other objects could be updated this way. Just as an example :

const nativeEvents = new Set([

@louismaximepiton louismaximepiton requested a review from a team as a code owner May 25, 2022 14:50
@GeoSot GeoSot added this to In progress in v5.2.0-stable via automation May 31, 2022
@GeoSot GeoSot force-pushed the main-lmp-reorder-js-objects branch from b4a6fa6 to 4abf687 Compare May 31, 2022 08:22
v5.2.0-stable automation moved this from In progress to Reviewer approved May 31, 2022
@XhmikosR
Copy link
Member

TBH I'm not sure how much this makes sense especially since it's not enforced. The docs order might be random too.

Just thinking out loud here.

Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dig it. Probably more we can update in our docs and elsewhere, so appreciate the start here!

@mdo mdo force-pushed the main-lmp-reorder-js-objects branch from 4abf687 to 4804a31 Compare June 2, 2022 01:44
@mdo mdo merged commit c137d11 into twbs:main Jun 2, 2022
v5.2.0-stable automation moved this from Reviewer approved to Done Jun 2, 2022
@louismaximepiton louismaximepiton deleted the main-lmp-reorder-js-objects branch September 2, 2022 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.2.0-stable
  
Done
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants