Update Sass for computing .table-group-divider border
#36446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdo
force-pushed
the
table-group-border-width
branch
from
806dc88
to
6c66cd5
Compare
iburakov
added a commit
to ryukzak/nitta
that referenced
this pull request
Jul 2, 2022
Resolving autoprefixer to 10.4.5 is needed to fix another warning which got fixed in bootstrap 5.2.0-beta1, but they seem to still have some problems. Why 5.2.0 is needed: twbs/bootstrap#36259 Why 5.2.0 doesn't work: postcss-calc swears on calc($sass-variable * 2) could not reproduce in other projects may be related: twbs/bootstrap#36446
iburakov
added a commit
to ryukzak/nitta
that referenced
this pull request
Jul 2, 2022
Resolving autoprefixer to 10.4.5 is needed to fix another warning which got fixed in bootstrap 5.2.0-beta1, but this produces new warnings, so falling back. Why 5.2.0 is needed: twbs/bootstrap#36259 Why 5.2.0 doesn't work: postcss-calc swears on ($table-border-width * 2) in bootstrap codebase could not reproduce in a minimal project to file an issue may be related: twbs/bootstrap#36446
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36441.
For context, reverted the
calc()usage here because we're not able to fully utilize CSS vars forborder-widthyet, due to existing Sass math usage.